Pg Client: BigDecimal support for reading numeric values #1509
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
we need tests :-) |
Contributor
Author
@vietj, I've updated the PR with tests and some fixes, please check |
Contributor
|
@alexpoletaev can you please sign the Eclipse Contributor Agreement (and sign-off your commit if you haven't already)? |
tsegismont
approved these changes
Apr 11, 2025
Contributor
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
LGTM, thank you @alexpoletaev
Contributor
|
@alexpoletaev I've reviewed the PR, let's see CI results. I won't be able to merged before you sign ECA though. |
tsegismont
changed the title
Contributor
Author
|
@tsegismont , I've have never done that before :) I created an Eclipse account, signed the ECA and revalidated the check. I believe it's OK now. Please let me know if it's not. Also I didn't know that I need to sign commits, could you please tell me what should I do if I already pushed unsigned commits? |
Contributor
|
It seems you figured it out, thanks again! |
tsegismont
pushed a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Apr 13, 2025
…tx#1509) * Fixes BigDecimal casting for the postgres client * Add tests. Fix row conversion for an array of BigDecimal elements
tsegismont
pushed a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Apr 13, 2025
…tx#1509) * Fixes BigDecimal casting for the postgres client * Add tests. Fix row conversion for an array of BigDecimal elements Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Apr 13, 2025
…tx#1509) * Fixes BigDecimal casting for the postgres client * Add tests. Fix row conversion for an array of BigDecimal elements Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
that referenced
this pull request
Apr 22, 2025
* Fixes BigDecimal casting for the postgres client * Add tests. Fix row conversion for an array of BigDecimal elements Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the same problem which is described in the #1473 , but for the postgres implementation